Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests showing some bugs (IMHO), i have discovered when using stateless updates #23

Closed
wants to merge 8 commits into from

Conversation

wobu
Copy link
Contributor

@wobu wobu commented May 7, 2013

No description provided.

@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

Unit test wobu@5b732f1 for issue #25

@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

Unit test wobu@fef37c7 for issue #26

@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

Unit test wobu@1d8be8b for issue #27

…auses inserts instead of updates -> Primary key violation
@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

Unit test wobu@e1f60a5 for issue #28

@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

Commit wobu@336d964 fix issue #28

@wobu wobu closed this May 9, 2013
@wobu wobu reopened this May 9, 2013
@wobu
Copy link
Contributor Author

wobu commented May 9, 2013

unintended closed pull request.. sry

@wobu
Copy link
Contributor Author

wobu commented May 17, 2013

added commits for issue #30

@rvowles
Copy link
Contributor

rvowles commented Jun 29, 2013

What is the state of these? Has Rob looked at them?

@wobu
Copy link
Contributor Author

wobu commented Jun 29, 2013

Rob said he wants to fix the bugs till the next major release, cause he is doing a huge refactoring of the byte code enhancement.

If he had already a look onto these bugs i don't know, but he fixed some other bugs in the last few days ;)

@rbygrave
Copy link
Member

Yes, I have been holding off looking at these stateless update tests/commits due to the enhancement changes which changed the stateless update implementation details almost completely (as there is no longer a need to specify the properties to update etc as the enhancement takes care of that).

So yes, if there is anything in here that is urgent lets raise that but if we can hold off to 'R4' which is perhaps a few weeks away that would be good.

@wobu
Copy link
Contributor Author

wobu commented Jul 1, 2013

@rbygrave

this pull requests contains a commit for a caching bug. Generally the caching bugs i have found are for me a greater pain in the ass :(
I like the caching feature a lot, but i also got a lot of headache finding workarounds for them.

Is it possible that you will at least have a look on them?

@rbygrave
Copy link
Member

rbygrave commented Jul 1, 2013

@wobu

There is already a fix for issue 30 in master - I have just updated that related commit linking to the commit in master.

Was there another fix? I didn't see one when I browsed through this just now.

@wobu
Copy link
Contributor Author

wobu commented Jul 2, 2013

rbygrave added a commit that referenced this pull request Apr 23, 2014
@rbygrave
Copy link
Member

I have merged all of these test cases into the develop-v4 branch. All tests passing - closing this now.

@rbygrave rbygrave closed this Apr 24, 2014
rbygrave added a commit that referenced this pull request Mar 7, 2023
… to flush last ChangeLog changes at PreCommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants