Initial DB2Luw9Platform using row_number() for row limiting sql #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
reviewed
Apr 26, 2023
| /** | ||
| * DB2 platform for Linux/Unix/Windows version 9.x. | ||
| */ | ||
| public class DB2Luw9Platform extends BaseDB2Platform { |
There was a problem hiding this comment.
Note: There is still the DB2LegacyPlatform as fallback which has very restrictive limits to 18 characters. (For V7 and below).
I think it makes sense to include the limiters also there.
platforms/db2/src/main/java/io/ebean/platform/db2/DB2RowNumberBasicLimiter.java
Outdated
Show resolved
Hide resolved
…BasicLimiter.java Bump StringBuilder to use 120 Co-authored-by: Roland Praml <roland.praml@foconis.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.