Implemented missing cache functions for Postgis module. #3036
Conversation
There was a problem hiding this comment.
It makes sense to me.
Side note:
I noticed that jsonRead/jsonWrite (and readData/writeData) is also not yet implemented.
If you mean, it makes sense to implement this, you may find a reference implementation here - but this should not be done in this PR
| try { | ||
| return new LineString(value); | ||
| } catch (SQLException e) { | ||
| throw new IllegalStateException(e); |
There was a problem hiding this comment.
I was wondering if it would make sense to include the erroneous value here as message argument, but as far as I can see LineString is already throwing a SqlException with the value included in the message
There was a problem hiding this comment.
As I think, this error should never occur. String value passed to constructor is generated with this same code (LineString#toString()). This could happen, when WTK string would be from external source, but this is not the case.
This is a fix for #3026. It resolves the problem. JUnit tests confirms this.
There is also a problem with
lattepackage mapping. This PR doesn't addresslattepackage mappings.