Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property.value use intercept to trigger lazy load #3057

Merged
merged 1 commit into from
May 23, 2023

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented May 16, 2023

Hello @rbygrave

we use often Property.value(bean) in our code, as this is the common interface of all properties.
Today, we discovered, that this method does not trigger lazy load and just returns null in such case.

My question is now, is this a mistake or intended. If intended, why is there no valueIntercept in Property?

cheers
Roland

@rob-bygrave
Copy link
Contributor

Right, now that #3058 is merged we can merge this PR in as there is now no internal use of Property.value() [only used in tests] so effectively only code will be using Property.value() and it's reasonable that it SHOULD invoke lazy loading if required when used this way.

@rob-bygrave rob-bygrave added this to the 13.18.0 milestone May 23, 2023
@rob-bygrave rob-bygrave merged commit d53ca87 into ebean-orm:master May 23, 2023
1 check passed
@rPraml rPraml deleted the property-value-intercept branch August 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants