Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated MetaInfoManager.collectMetricsAsJson() - move to co… #3087

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

rbygrave
Copy link
Member

@rbygrave rbygrave commented Jun 1, 2023

…llectMetrics().asJson()

Removing these deprecated methods:

  • collectMetricsAsJson() -> collectMetrics().asJson();
  • collectMetricsAsData() -> collectMetrics().asData()
  /**
   * Deprecated migrate to collectMetrics().asJson().
   */
  @Deprecated
  default ServerMetricsAsJson collectMetricsAsJson() {
    return collectMetrics().asJson();
  }

  /**
   * Deprecated migrate to collectMetrics().asData().
   */
  @Deprecated
  default List<MetricData> collectMetricsAsData() {
    return collectMetrics().asData();
  }

…llectMetrics().asJson()

Removing these deprecated methods:
- collectMetricsAsJson() -> collectMetrics().asJson();
- collectMetricsAsData() -> collectMetrics().asData()

```java
  /**
   * Deprecated migrate to collectMetrics().asJson().
   */
  @deprecated
  default ServerMetricsAsJson collectMetricsAsJson() {
    return collectMetrics().asJson();
  }

  /**
   * Deprecated migrate to collectMetrics().asData().
   */
  @deprecated
  default List<MetricData> collectMetricsAsData() {
    return collectMetrics().asData();
  }
```
@rbygrave rbygrave added this to the 13.19.0 milestone Jun 1, 2023
@rbygrave rbygrave self-assigned this Jun 1, 2023
@rbygrave rbygrave merged commit 59a3766 into master Jun 1, 2023
2 checks passed
@rbygrave rbygrave deleted the deprecated/collectMetricsAsJson branch June 1, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant