Bugfix for wrong batch statement ordering with many2many relations #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-many elements (size > 20) (cherry picked from commit e6a4bc4)
…do not conflict with the following inserts
jonasPoehler
commented
Jun 16, 2023
| @@ -267,8 +270,8 @@ public void clear() { | |||
| private void flushBuffer(boolean reset) throws BatchedSqlException { | |||
| flushQueue(queues[0]); | |||
There was a problem hiding this comment.
We were unable to find a use of the queue at position 0. Maybe this one is unused?
There was a problem hiding this comment.
Ah ok ... hmm, I need to look at that.
rbygrave
approved these changes
Jun 16, 2023
| @@ -267,8 +270,8 @@ public void clear() { | |||
| private void flushBuffer(boolean reset) throws BatchedSqlException { | |||
| flushQueue(queues[0]); | |||
There was a problem hiding this comment.
Ah ok ... hmm, I need to look at that.
| @@ -294,7 +294,7 @@ private void saveAssocManyIntersection(boolean queue) { | |||
| // build a intersection row for 'delete' | |||
| IntersectionRow intRow = many.buildManyToManyMapBean(parentBean, otherDelete, publish); | |||
| SpiSqlUpdate sqlDelete = intRow.createDelete(server, DeleteMode.HARD); | |||
| persister.executeOrQueue(sqlDelete, transaction, queue); | |||
| persister.executeOrQueue(sqlDelete, transaction, queue, BatchControl.DELETE_QUEUE); | |||
rbygrave
added a commit
that referenced
this pull request
Jun 16, 2023
rbygrave
added a commit
that referenced
this pull request
Jun 16, 2023
Followup to #3113, remove unused first BatchControl queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rob,
this PR fixes an issue, when a List representing a ManyToMany-relation is cleared and then filled with (some of) the original elements. Functionally this resulted in the delete and the following insert statements to be executed within the same batch queue, because with m2m intersection tables the same queue was used for both types of SqlUpdate. The end result was that in these cases the first insert statements were executed before all delete statements were flushed, resulting in a DuplicateKeyException. Additionally, I introduced constants for the delete and insert queue positions for better readability.