QueryBean generation - use full class names for TQRootBean, TQAssocBean #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than imports, such that these are not possible name clashes with beans of the exact same name.
|
Don't you think that all EBean API classes should be full qualified in generated code? As soon as there is an import to any Ebean API class, that class name can not be used as entity name. Looking at the current file there is |
Well there is a requirement that the generated code is "pretty readable" for humans to read. We probably should fully qualify |
If there is an entity bean short name clash like PString, PLong, etc then fully qualify all the property types in the generated code, otherwise use imports for the property types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than imports, such that these are not possible name clashes with beans of the exact same name.