Separate column for android subversions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
Mar 17, 2022
| @@ -215,14 +215,14 @@ This is an overview of all Android versions and their corresponding identifiers | |||
| <td><code>JELLYBEAN</code></td> | |||
| </tr> | |||
| <tr> | |||
| <td>4.0.3 – 4.0.4</td> | |||
There was a problem hiding this comment.
I think it was better before. More space, but more explicit and therefore easier to read and understand.
TWiStErRob
reviewed
Mar 17, 2022
| @@ -12,7 +12,9 @@ This is an overview of all Android versions and their corresponding identifiers | |||
|
|
|||
| <table class="full-width"> | |||
| <tr> | |||
| <th>Version</th> | |||
| <th colspan="2"> | |||
There was a problem hiding this comment.
I would move the API Level column first, after all that's the "key" in this table and even your website is named after it. Everything else is explaining/detailing API levels.
So: API Level, Version Code, Codename, Version, Codename
(not sure about Codename's location, either of those two)
TWiStErRob
reviewed
Mar 17, 2022
| <tr> | ||
| <td>Level 31 <span class="subversion">Android 12</span></td> | ||
| <td>12</td> |
There was a problem hiding this comment.
I would still bring in some of my changes from #14, because the inconsistency of 4 missing cells probably raises more eyebrows than the missing empty spaces gives wins.
|
What do we need to get this in? |
|
Bump ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with moving the Android subversions (e.g. 12, 12L) into a separate subcolumn of the "Versions" column.