Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth response to json #32

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

ebenezerdon
Copy link
Owner

This PR refactors auth response to json format
The auth response is now a json object with keys, token and success
PT story for this PR is ch[#161859749]

@ebenezerdon ebenezerdon merged commit c640045 into develop Nov 10, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 164

  • 40 of 41 (97.56%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 85.973%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/routes/middleware/validateinput.js 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
server/routes/middleware/verify.js 1 93.55%
server/routes/middleware/validateinput.js 1 86.21%
server/routes/controllers/usersController.js 1 52.38%
Totals Coverage Status
Change from base Build 162: -0.8%
Covered Lines: 505
Relevant Lines: 553

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants