Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162067435 Implement status messages #70

Merged
merged 4 commits into from
Nov 21, 2018

Conversation

ebenezerdon
Copy link
Owner

This PR implements the display of status message in the login page

It also refactors the login error return message in the API

PT story for this PR is ch[#162067435]

Add content to snackbar.css for styling of status messages
Return error messages for login page in snackbar
Refactor return message in login controller to json object format
Move snackbar code to login.js
Delete snackbar.js as it is no longer needed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 306

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/routes/controllers/usersController.js 2 3 66.67%
Totals Coverage Status
Change from base Build 304: -0.1%
Covered Lines: 508
Relevant Lines: 556

💛 - Coveralls

@ebenezerdon ebenezerdon merged commit 152dfb2 into develop Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants