Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to drop alias migration #31

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Aug 12, 2020

Fixes ticket #268

Tested the migration locally

@ke4 ke4 requested a review from a team August 12, 2020 08:56
Copy link
Contributor

@MightyAx MightyAx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested without either an archiveEntity collection in mongo or MongoRepository<ArchiveEntity, String>
This migration applies successfully.

@MightyAx
Copy link
Contributor

@ke4 I'm happy to merge this and take you through the steps required to deploy to staging tomorrow.

@ke4
Copy link
Contributor Author

ke4 commented Aug 13, 2020

That would be cool @MightyAx, but I would like to do as much as possible myself with the help/direction by you, because I think that's how I would learn the process. Many thanks 👍

@ke4 ke4 merged commit 877f9e0 into master Aug 13, 2020
@ke4 ke4 deleted the bug/add-check-to-drop-alias-migration branch August 13, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants