Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up framework for handling questionnaire data #28

Merged
merged 6 commits into from
Jul 29, 2020

Conversation

rdgoite
Copy link
Contributor

@rdgoite rdgoite commented Jul 23, 2020

  • Restructured the code for downloading the dummy spreadsheet to use service that's intended to invoke the template generator backend.
  • Initially defined framework for processing form data into template specification.

@rdgoite rdgoite requested a review from a team July 23, 2020 12:06
@rolando-ebi
Copy link
Contributor

@rdgoite looks good so far, but also requires the mechanism whereby the broker's HTTP API responds with a URL for the asynchronously generated spreadsheet. The UI should then poll that URL until the spreadsheet file is available to download

@rdgoite
Copy link
Contributor Author

rdgoite commented Jul 23, 2020

While the framework is built for now with the assumption that the spreadsheet will be (almost) instantly ready, the services and components can be modified to to accommodate async generation.

However, from a usability perspective, how would that work? Do we need something like a modal box to tell the user that we're generating the template while we poll the URL in the background?

@rolando-ebi
Copy link
Contributor

Yeah, I was under the impression we were going to have UI mock-ups for a spinny loading wheel or something like that while the spreadsheet is generated in the background

@rolando-ebi
Copy link
Contributor

I asked Clare about this. She said there are no mockups, but for now we should just change the "generate" button to "generating" while we're awaiting the spreadsheet blob

@MightyAx
Copy link
Contributor

@rdgoite @rolando-ebi: we do have spinny wheel that we can show while something takes some time, check out the loader service here:

@@ -0,0 +1,14 @@
export interface QuestionnaireData {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't account for the full schema of info specified here

Also how does this account for the schema changing? (as @ami-day is currently doing)

Copy link
Contributor

@aaclan-ebi aaclan-ebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this and apply more changes later.

@aaclan-ebi aaclan-ebi merged commit 52ce09c into master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants