-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up framework for handling questionnaire data #28
Conversation
rdgoite
commented
Jul 23, 2020
- Restructured the code for downloading the dummy spreadsheet to use service that's intended to invoke the template generator backend.
- Initially defined framework for processing form data into template specification.
@rdgoite looks good so far, but also requires the mechanism whereby the broker's HTTP API responds with a URL for the asynchronously generated spreadsheet. The UI should then poll that URL until the spreadsheet file is available to download |
While the framework is built for now with the assumption that the spreadsheet will be (almost) instantly ready, the services and components can be modified to to accommodate async generation. However, from a usability perspective, how would that work? Do we need something like a modal box to tell the user that we're generating the template while we poll the URL in the background? |
Yeah, I was under the impression we were going to have UI mock-ups for a spinny loading wheel or something like that while the spreadsheet is generated in the background |
I asked Clare about this. She said there are no mockups, but for now we should just change the "generate" button to "generating" while we're awaiting the spreadsheet blob |
@rdgoite @rolando-ebi: we do have spinny wheel that we can show while something takes some time, check out the loader service here:
|
@@ -0,0 +1,14 @@ | |||
export interface QuestionnaireData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this and apply more changes later.