Fix drag drop update outside scroll container #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already an update triggered right after, with the correct data e.g. the hovered element. This extra update was always done with droppable false and no element.
No need to create args unless we鈥檙e really using it.
mat007
force-pushed
the
fix-drag-drop-update-outside-scroll-container
branch
from
a2d2558
to
1bfa0f6
Compare
mcarpenter622
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes on top of #107, #108, and only the last commit is new.
Sorry about that, I tried to make small easier to review PRs, but at this point it鈥檚 become hard to keep them all separate 馃槵
I鈥檒l rebase this PR if/when the other PRs are merged, if that makes it easier to review.
Applying this patch to the
scrollcontainerexample exposes the following problem: the update and end callbacks are triggered with an element match on a widget that鈥檚 outside the scroll container.This is shown in the following video where we press one of the buttons, then drag around outside the scroll viewport: the bug is the
update drag trueat the end.