Magento 2.2.4: Ensure Message objects are the same on both TransportB… #66
Conversation
Silarn
force-pushed
the
develop
branch
2 times, most recently
from
ba7c718
to
c8eea3b
Compare
|
Working on this. Tests have to be updated and I'm trying to set up a test for the new class. |
Silarn
force-pushed
the
develop
branch
6 times, most recently
from
26763e3
to
e9a5263
Compare
|
This fix is good. The tests are updated for Magento 2.2.4. I threw in a PHP 7.1 test path for completeness but it's not required. I'm still not certain why the default code is not using a singleton for the Mandrill Message object. It's possible there's still a DI-based fix that could correct the problem but I was unable to find it with the time I have available. |
Silarn
force-pushed
the
develop
branch
2 times, most recently
from
3f6e840
to
e1c8cbd
Compare
|
Is this still compatible with 2.1.x after this change? |
|
No, which is why I put the dependency into the composer file. If there's a di solution which can ensure the same message instance is used by both transport builder models without having to override SenderBuilder then you might be able to keep it backwards compatible. |
|
When can we expect the patched version? |
|
Merging this will make the extension not compatible with Magento 2.1.x. I think the solution is to have 2 branches, one for 2.1.x and one for 2.2.x given this change is not compatible with 2.1. Then, we would have for example for 2.1 -> 3.1.x Branch (or 3.0.x) |
…uilder classes
This fixes #65