Expose cargo failures #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if [ $? -ne 0 ]; then | ||
| echo "--- Passed!" | ||
| echo |
There was a problem hiding this comment.
There is something of a spacing issue here on line 83. Not very important, but my OCD just kicked in. 😉
|
@White-Oak Besides the two comments above, this looks pretty good. I'm going to build this on my local machine to try it out. Just fix the spacing on that one line, and it will be merge-ready. |
Attempted to fix spacing in changed code in tests.sh.
|
Thanks for the changes, @White-Oak! This and pull request #14 together bring us almost ready to closing issue #13. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo::callproperly returnsSome()(I still think it should beResultinstead ofOption) if cargo task has failed (exited with non-zero status).