Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move localModList from main Vuex store to ProfileModule #1228

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

anttimaki
Copy link
Collaborator

"local" in the variable name refers to locally installed mods, i.e. the mods currently included in the profile. It therefore makes sense for the mod list to be part of the ProfileModule.

@anttimaki
Copy link
Collaborator Author

Requires related changes to TSMM, currently in draft PR state.

Copy link
Collaborator

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from disable-all-setting to develop February 22, 2024 12:57
"local" in the variable name refers to locally installed mods, i.e.
the mods currently included in the profile. It therefore makes sense
for the mod list to be part of the ProfileModule.
@anttimaki anttimaki merged commit 559c89a into develop Feb 23, 2024
7 checks passed
@anttimaki anttimaki deleted the move-local-mod-list-store branch February 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants