Move resetting mod list back to Profiles.vue #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b17d878 moved this bit of code from Profiles.vue to Manager.vue since it makes for the latter to handle the state manipulation that affects its own contents. However, Vue doesn't await beforeCreate(), which opened up a race condition where it's technically possible for the updating of the mod list with an empty array to complete last, causing the view to render an empty state. While placing this bit of code in Profiles.vue is not ideal, at least it works since the method is awaited there.
MythicManiac
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b17d878 moved this bit of code from Profiles.vue to Manager.vue since it makes for the latter to handle the state manipulation that affects its own contents.
However, Vue doesn't await beforeCreate(), which opened up a race condition where it's technically possible for the updating of the mod list with an empty array to complete last, causing the view to render an empty state.
While placing this bit of code in Profiles.vue is not ideal, at least it works since the method is awaited there.