Limit the size of the profiles exported as a code to 20MB #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anttimaki
commented
Mar 5, 2024
anttimaki
commented
Allows pretty printing file sizes for human digestion.
If the zipped payload of the profile exceeds the limit, the process is cancelled before the B64 encoding and upload steps, and an error modal is shown to the user. The size is limited firstly because there shouldn't be need for larger profiles, and exceeding the limit is a symptom of something being wrong, e.g. unintended contents in the BepInEx config folder. Second reason is that too large profiles will crash on the B64 encoding step on TSMM, which uses different file operation implementation than r2mm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.