Make UninstallModModal more self-sustained #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to pass dependants list as a prop since it can be as easily be determined internally. Dependency list prop was dropped altogether since it's not used.
While the mod itself would be enough to determine the state without a separate boolean value, I decided to use both to stay consistent with the other modals handled by ModalsModule store.
The implementation imitates what's currently being done by LocalModList.performUninstallMod(). This helps remove business logic and direct references to providers from components, hopefully supporting reuse and easier refactoring.
The modal now handles uninstalling of mods entirely internally.
LocalModCard now uninstalls mods without dependants internally, and delegates mods with dependants to UninstallModModal, effectively cutting out the middleman LocalModList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.