Add support for 5 new games #980
Conversation
MythicManiac
force-pushed
the
new-games
branch
from
8f1e251
to
c1f06e7
Compare
| import Game from 'src/model/game/Game'; | ||
| import { Depot } from '../../depots/loader/Depot'; | ||
| import R2Error from '../../model/errors/R2Error'; | ||
| import Game from '../../model/game/Game'; |
There was a problem hiding this comment.
Ah thanks, it's annoying that I can't configure webstorm to resolve to relative imports
src/model/game/GameManager.ts
Outdated
| "Dome Keeper", ["domekeeper.exe"], "", | ||
| "https://thunderstore.io/c/dome-keeper/api/v1/package/", "https://raw.githubusercontent.com/ebkr/r2modmanPlus/master/modExclusions.md", | ||
| [new StorePlatformMetadata(StorePlatform.STEAM, "1637320")], "dome-keeper.jpg", | ||
| GameSelectionDisplayMode.VISIBLE, GameInstanceType.GAME, PackageLoader.GODOT_ML, []), |
There was a problem hiding this comment.
Nit: "dk" is probably alright for a shorthand in the last array.
| "Skul", ["Skul.exe"], "Skul_Data", | ||
| "https://thunderstore.io/c/skul-the-hero-slayer/api/v1/package/", "https://raw.githubusercontent.com/ebkr/r2modmanPlus/master/modExclusions.md", | ||
| [new StorePlatformMetadata(StorePlatform.STEAM, "1147560")], "skul-the-hero-slayer.jpg", | ||
| GameSelectionDisplayMode.VISIBLE, GameInstanceType.GAME, PackageLoader.BEPINEX, []), |
There was a problem hiding this comment.
I thought about this but I'm pretty sure the actual shorthand for the game is just "skul", which is already discoverable
| @@ -181,10 +181,24 @@ export default class GenericProfileInstaller extends ProfileInstallerProvider { | |||
| } | |||
| } | |||
|
|
|||
| private async installGodotML(mlLocation: string, modLoaderMapping: ModLoaderPackageMapping, profile: Profile) { | |||
| const copyFrom = path.join(mlLocation, "addons", "mod_loader"); | |||
There was a problem hiding this comment.
Do we not want to copy the addons folder entirely?
There was a problem hiding this comment.
I was considering this from the perspective of cleanup (if cleanup would be necessary), so I figured it's more appropriate to be explicit about the structure as it makes cleanup at least possible if it becomes necessary. Otherwise we'd have to delete all the addons or implement some state tracking.
| Brotato: [ | ||
| // TODO: Add godot mod loader support | ||
| ], | ||
| Brotato: [], |
There was a problem hiding this comment.
Is there no GodotModding-GodotModLoader package for Brotato?
There was a problem hiding this comment.
Brotato has it built in
Add support for the following games: - RUMBLE - Dome Keeper - Skul: The Hero Slayer - Sons Of The Forest - The Ouroboros King Additionally, include support for installing the godot mod loader package, as dome keeper needs it and it wasn't implemented yet.
MythicManiac
force-pushed
the
new-games
branch
from
c1f06e7
to
bed0ea7
Compare
Add support for the following games:
Additionally, include support for installing the godot mod loader package, as dome keeper needs it and it wasn't implemented yet.