Add a designated Attribute #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ebln
commented
Jun 2, 2024
•
ebln
commented
- add support for attributes of PHP8+
- update gh actions
- update psalm
ebln
force-pushed
the
attributes
branch
2 times, most recently
from
35f29b0
to
85c335c
Compare
ebln
force-pushed
the
attributes
branch
2 times, most recently
from
67bb77a
to
19c79d4
Compare
- ExtendedProduct wasn't resolved and needed extra TLC TODO: Tests for mixed occurrences of Interface and Attributes Add attributes from spike - yet without tests
i.e. where on hasn't installed this rule
→ \Ebln\Attrib\ForceFactory
PHPStan yells at `Attribute class INVALID\NOT\FOUND\ATTRIBUTE does not exist.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.