Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebooting / shutting down the eBlocker by the user should not be allowed during an update #337

Open
eblosug opened this issue Mar 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@eblosug
Copy link
Member

eblosug commented Mar 13, 2024

The UI allows rebooting or shutting down the eBlocker if:

  • automatic updates are currently in progress
  • the API method /api/adminconsole/updates/status has not been called yet.

In this case a reboot or shutdown would interrupt the update.

The above API method is only called if the admin loads one of the following tabs:

  • License & Update / Update
  • Blocker
@eblosug eblosug added the bug Something isn't working label Mar 13, 2024
@eblosug
Copy link
Member Author

eblosug commented Mar 13, 2024

The issue does not occur, because the updater uses the UpdateStatusObserver class to set the system state to UPDATING temporarily.

@eblosug eblosug closed this as completed Mar 13, 2024
@eblosug
Copy link
Member Author

eblosug commented Mar 14, 2024

The issue still occurs. Although the system status at /api/adminconsole/systemstatus has the correct executionState UPDATING, the updatingStatus element does not exist. Therefore the updating screen in the UI does not show any progress.

AND: the settings can be opened again in the browser by entering eBlocker's IP in the URL bar. The updating screen does not appear and it is possible to shutdown the eBlocker.

@eblosug eblosug reopened this Mar 14, 2024
@eblosug
Copy link
Member Author

eblosug commented Mar 14, 2024

It's even worse:

  • Go to License & Update / Update and start a manual update
  • The updating screen showing progress is shown
  • Close the browser window
  • Open a new window and enter eBlocker's IP to load the settings
  • The updating screen is not shown although the eBlocker is still updating
  • Shut down the eBlocker, interrupting the update.

@eblosug
Copy link
Member Author

eblosug commented Mar 14, 2024

At least the backend should make sure that the user can not initiate a reboot or shutdown during an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant