fix #73

eblondel · Mar 11, 2024 · b34e9c6 · b34e9c6
1 parent 1b41f65
commit b34e9c6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: geosapi
 Type: Package
 Title: GeoServer REST API R Interface
-Version: 0.7
-Date: 2024-02-27
+Version: 0.7-1
+Date: 2024-03-11
 Authors@R: c(person("Emmanuel", "Blondel", role = c("aut", "cre"), email = "emmanuel.blondel1@gmail.com", comment = c(ORCID = "0000-0002-5870-5762")))
 Maintainer: Emmanuel Blondel <emmanuel.blondel1@gmail.com>
 Description: Provides an R interface to the GeoServer REST API, allowing to upload 

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+## [geosapi 0.7-1](https://cran.r-project.org/package=geosapi) | [![CRAN_Status_Badge](https://img.shields.io/badge/CRAN-published-blue.svg)](https://cran.r-project.org/package=geosapi)
+
+**Corrections**
+
+* [#73](https://github.com/eblondel/geosapi/issues/73) Bad XML encoding for entryset
+
 ## [geosapi 0.7](https://cran.r-project.org/package=geosapi) | [![CRAN_Status_Badge](https://img.shields.io/badge/CRAN-published-blue.svg)](https://cran.r-project.org/package=geosapi)
 
 **Enhancements**

diff --git a/R/GSRESTResource.R b/R/GSRESTResource.R
@@ -60,11 +60,12 @@ GSRESTResource <- R6Class("GSRESTResource",
             itemValue <- items[[itemName]]
             if(is.logical(itemValue)){
               itemValue <- tolower(as.character(itemValue))
-              xml2::xml_text(item) <- itemValue
             }
             if(is(itemValue, "GSRESTResource")){
               itemValue <- itemValue$encode()
               item %>% xml2::xml_add_child(itemValue)
+            }else{
+              xml2::xml_text(item) <- itemValue
             }
             rootXML %>% xml2::xml_add_child(item)
           }

diff --git a/README.md b/README.md
@@ -4,7 +4,7 @@
 [![Build Status](https://github.com/eblondel/geosapi/actions/workflows/r-cmd-check.yml/badge.svg?branch=master)](https://github.com/eblondel/geosapi/actions/workflows/r-cmd-check.yml)
 [![CRAN_Status_Badge](http://www.r-pkg.org/badges/version/geosapi)](https://cran.r-project.org/package=geosapi)
 [![cran checks](https://badges.cranchecks.info/worst/geosapi.svg)](https://cran.r-project.org/web/checks/check_results_geosapi.html)
-[![Github_Status_Badge](https://img.shields.io/badge/Github-0.7-blue.svg)](https://github.com/eblondel/geosapi)
+[![Github_Status_Badge](https://img.shields.io/badge/Github-0.7--1-blue.svg)](https://github.com/eblondel/geosapi)
 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.1184895.svg)](https://doi.org/10.5281/zenodo.1184895)
 
 ``geosapi``: GeoServer REST API R Interface