Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpublishLayer doc #34

Closed
fxi opened this issue Dec 6, 2018 · 2 comments
Closed

unpublishLayer doc #34

fxi opened this issue Dec 6, 2018 · 2 comments
Assignees
Milestone

Comments

@fxi
Copy link

fxi commented Dec 6, 2018

Hi,

There is a typo in doc version 0.3-0 . For unpublishLayer, it gives us 4 parameters, but the function takes only 3.

code:

 gsman$unpublishLayer
function (ws, ds, lyr)
{
    self$INFO(sprintf("Unpublishing layer '%s'", lyr))
    unpublished <- FALSE
    (...)
    return(unpublished)
}

doc:

‘unpublishLayer(ws, ds, featureType, layer)’ Unpublish a web-layer (including the featureType and 'layer' resources), given a workspace, a datastore, and a layer name

As I am here, is there a way to enable services by workspace ? Example, WMS but not WCS or only WMS ? The API seems to give us something like that with /workspaces/<ws>/settings, but what would be the strategy from geosapi ?

Thanks !

eblondel added a commit that referenced this issue Dec 6, 2018
@eblondel
Copy link
Owner

eblondel commented Dec 6, 2018

Thanks @fxi i've fixed the Rdoc.

For what concerns your request, Settings management seems indeed supported by the API, but this feature is not (yet) part of geosapi.

@eblondel eblondel self-assigned this Dec 6, 2018
@eblondel eblondel added this to the 0.3 milestone Dec 6, 2018
@fxi
Copy link
Author

fxi commented Dec 6, 2018

That was quick :)
I will speak with my team to see what we can do to contribute bounty-wise or code-wise.
Thanks !

@eblondel eblondel modified the milestones: 0.3, 0.4 Dec 13, 2018
eblondel added a commit that referenced this issue Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants