Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty firstname in addContributor() #117

Closed
ThierryO opened this issue Mar 20, 2023 · 2 comments
Closed

Allow empty firstname in addContributor() #117

ThierryO opened this issue Mar 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ThierryO
Copy link

This is allowed in addCreator() (see #26)

Maybe simple change

contributor <- list(name = paste(lastname, firstname, sep=", "), type = type)

into

contributor <- list(name = paste(c(lastname, firstname), collapse=", "), type = type) 

A contributor can be an entity (e.g. organisation which is the copyright holder).

@eblondel eblondel self-assigned this Mar 20, 2023
@eblondel eblondel added the enhancement New feature or request label Mar 20, 2023
@eblondel eblondel added this to the 0.9 milestone Mar 20, 2023
eblondel added a commit that referenced this issue Mar 20, 2023
eblondel added a commit that referenced this issue Mar 20, 2023
@eblondel
Copy link
Owner

@ThierryO i've pushed some code , let me know if it's ok

@ThierryO
Copy link
Author

Thanks for the fast response. It works as expected.

I'm working on an upload function depending on a path containing a .zenodo.json. Maybe an idea to incorpate in zen4R?

eblondel added a commit that referenced this issue Mar 21, 2023
@eblondel eblondel closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants