Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 573295f breaks publish: false in geoflow #125

Closed
kikislater opened this issue Aug 24, 2023 · 8 comments
Closed

Commit 573295f breaks publish: false in geoflow #125

kikislater opened this issue Aug 24, 2023 · 8 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kikislater
Copy link

kikislater commented Aug 24, 2023

if we set publish: false, commit 573295f breaks workflow

json conf:

 "actions": [
    {
      "id": "zen4R-deposit-record",
      "options": {
          "update_files": true,
          "communities": "ecfunded",
          "depositWithFiles": true,
          "publish": false,
          "strategy": "newversion",
          "deleteOldFiles": true
      },
      "run": true
    }
  ]

It sends json with this:

>> {
>>   "stats": []
>>   "title": "Raw images - Session 20230507 Ifaty Plancha01",
>>   "state": "unsubmitted",
>>   "record_id": 1234649,
[....]
>> }

Whereas api/deposit/depositions/{id} json doesn't have stats. Only api/records/{id} have

v0.8 works fine. v0.9 doesn't work !

@kikislater
Copy link
Author

@juldebar

@eblondel
Copy link
Owner

@kikislater I assume that your workflow points to records that have been already published, right?

@kikislater
Copy link
Author

No, not published, in draft mode. So considering editing an existing draft deposit prior publishing

@kikislater
Copy link
Author

So of course there is no stats from api in draft mode ...

@kikislater kikislater changed the title Commit 573295f484817ce2c885504c1293cb7980a85c82 breaks publish: false in geoflow Commit 573295f breaks publish: false in geoflow Aug 30, 2023
@kikislater kikislater changed the title Commit 573295f breaks publish: false in geoflow Commit 573295f breaks publish: false in geoflow Aug 30, 2023
@eblondel eblondel self-assigned this Aug 30, 2023
@eblondel eblondel added the bug Something isn't working label Aug 30, 2023
@eblondel eblondel added this to the 0.9 milestone Aug 30, 2023
@eblondel
Copy link
Owner

ok got it, let me see if I can fix it quickly

eblondel added a commit that referenced this issue Aug 30, 2023
@eblondel
Copy link
Owner

Done, for your check

@kikislater
Copy link
Author

Thanks, btw I will use cran version

@eblondel
Copy link
Owner

Thanks, btw I will use cran version

zen4R 0.9 is on CRAN, you can update your env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants