Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download_zenodo() issue with md5sum #38

Closed
ivan-paleo opened this issue Aug 25, 2020 · 3 comments
Closed

download_zenodo() issue with md5sum #38

ivan-paleo opened this issue Aug 25, 2020 · 3 comments
Assignees
Labels
bug
Milestone

Comments

@ivan-paleo
Copy link

@ivan-paleo ivan-paleo commented Aug 25, 2020

I have some integrity issues when I download the files of a Zenodo record.

If I do that for example:
zen4R::download_zenodo("10.5281/zenodo.3632517")
the files are downloaded correctly but I have warnings about the md5sums that do not match.

Looking into the files, it seems that empty lines have been inserted everywhere, leading to different files from the originals (compare e.g. "Script3_plots.Rmd" when downloaded through zen4R and when downloaded directly from Zenodo).

Any idea what's causing it?

@eblondel eblondel self-assigned this Aug 25, 2020
@eblondel eblondel added the bug label Aug 25, 2020
@eblondel eblondel added this to the 0.4 milestone Aug 25, 2020
eblondel added a commit that referenced this issue Aug 25, 2020
@eblondel
Copy link
Owner

@eblondel eblondel commented Aug 25, 2020

thanks @ivan-paleo for reporting, i fixed download.file call, can you reinstall package and retry? It should work now

@ivan-paleo
Copy link
Author

@ivan-paleo ivan-paleo commented Aug 25, 2020

@eblondel That's the quickest fix ever!
Thank you very much for the great tool.

@eblondel
Copy link
Owner

@eblondel eblondel commented Aug 25, 2020

@ivan-paleo thanks you're welcome. Feel free to report other issues.

@eblondel eblondel closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.