-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ZenodoManager anonymous (token-less) calls keyring-free #45
Comments
Coming a bit late to this, 1) thanks for this package and 2) how would you recommend using a token... whilst on a CI system? (we have a workflow building a bookdown book on GitHub Actions and use zen4R). |
@maelle , so you don't want to use keyring to get system credentials? https://r-lib.github.io/keyring/index.html |
@PietrH I wanted to know whether there were some tips related to using it on GitHub Actions :-) |
I've never used it, but I know you can pipe in secrets via https://docs.github.com/en/actions/reference/encrypted-secrets |
@maelle i'm setting up a github action for R CMD check (previously was done on Travis) in order to consolidate some integrateion tests. There i'm using a a secret token from my Github to interact with the Zenodo sandbox:
Zen4R now relies on keyring to get system credentials, and token is not anymore stored as field of the |
thank you @eblondel! |
Another question (happy to use another communication channel if better): from Zen4R, can one choose what keyring backend to use? Another approach to authentication in opencage: having a function for authenticating but suggesting the use of keyring https://docs.ropensci.org/opencage/articles/opencage.html#authentication |
not yet, for the timebeing i've put a default to env, but i will see to make it as argument or option; |
@maelle i've pushed some enhancement to let user define the |
This is not an issue as long as keyring is installed on machines. It is essentially an issue on CRAN checks (Fedora, Macos flavors) and for R codes that are tested / run on CRAN checks, as it is the case in reverse depends GermaParl package (use of zen4R for data downloads from DOI).
The purpose is to bind the keyring use when a token is specified. When anonymous / tokenless use (token = NULL), the keyring functions should not be invoked.
The text was updated successfully, but these errors were encountered: