Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop assertthat and dplyr dependencies #40

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

florisvdh
Copy link
Contributor

Fewer dependencies will speed up installation and loading; assertthat and dplyr were almost not used.

The assert_that() precondition in human_filesize() could be dropped IMO because it is an internal function.

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #40 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage    5.75%   5.77%   +0.02%     
=========================================
  Files           7       7              
  Lines        1113    1108       -5     
=========================================
  Hits           64      64              
+ Misses       1049    1044       -5     
Impacted Files Coverage Δ
R/ZenodoRecord.R 0.00% <0.00%> (ø)
R/zen4R_downloader.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca3614...6966972. Read the comment docs.

@eblondel eblondel merged commit 23eb128 into eblondel:master Sep 2, 2020
@florisvdh florisvdh deleted the humansize branch September 2, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants