Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New sql and tests #120

Merged
merged 14 commits into from May 21, 2018
Merged

New sql and tests #120

merged 14 commits into from May 21, 2018

Conversation

sebbacon
Copy link
Contributor

@sebbacon sebbacon commented Mar 12, 2018 •
edited

This is WIP.

Next steps

  • make the gsutil part of the tests work by uploading a secret config to Travis
  • review for readability
  • ensure we're testing something useful (e.g. the things added to the SQL)
  • consider calling process_data directly rather than via a shell
  • consider merging load_data and process_data

@sebbacon sebbacon mentioned this pull request Mar 12, 2018
Closed
@sebbacon sebbacon mentioned this pull request May 21, 2018
Closed
@sebbacon sebbacon merged commit 7d942ba into master May 21, 2018
@sebbacon sebbacon deleted the new-sql-and-tests branch May 21, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sebbacon