Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle edited tech support messages #395

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Jan 11, 2024

Checks edited messages for the tech-support keyword, in case an initial request for tech-support was mistyped and so failed to actually call tech-support.

If the message was edited for something other than the tech-support keyword, it will have already been reacted to, so the attempt to add the SOS reaction will fail - but this is fine and what we want really, to avoid duplicate tech-support reposting.

Fixes #310

@rebkwok rebkwok marked this pull request as draft January 11, 2024 13:18
@rebkwok rebkwok force-pushed the edited-tech-support-messages branch 2 times, most recently from 6cd9157 to dd52ec9 Compare January 11, 2024 16:43
@rebkwok rebkwok changed the base branch from main to more-help January 11, 2024 16:44
@rebkwok rebkwok force-pushed the edited-tech-support-messages branch from dd52ec9 to 51a2570 Compare January 11, 2024 16:49
@rebkwok rebkwok force-pushed the edited-tech-support-messages branch from 51a2570 to 39e3232 Compare January 11, 2024 16:56
@rebkwok rebkwok marked this pull request as ready for review January 11, 2024 17:00
Check edited messages for tech-support keyword, in case an initial
request for tech-support was mistyped.
@rebkwok rebkwok force-pushed the edited-tech-support-messages branch from 39e3232 to d8fdb02 Compare January 12, 2024 09:10
Base automatically changed from more-help to main January 15, 2024 14:44
@rebkwok rebkwok merged commit 3c02e12 into main Jan 15, 2024
6 checks passed
@rebkwok rebkwok deleted the edited-tech-support-messages branch January 15, 2024 15:07
rebkwok added a commit that referenced this pull request Jan 15, 2024
…essages"

This reverts commit 3c02e12, reversing
changes made to 03d619d.
bloodearnest added a commit that referenced this pull request Jan 15, 2024
Revert "Merge pull request #395 from ebmdatalab/edited-tech-support-m…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tech-support handler is not triggered if added to a slack message in an edit
2 participants