Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add q2view display application. #1

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Conversation

blankenberg
Copy link

Requires configuring CORS and using https on Galaxy with these default settings.

<?xml version="1.0"?>
<display id="q2view" version="1.0.0" name="view at">
<dynamic_links from_data_table="q2view_display" skip_startswith="#" id="value" name="name">
<url>${ url % { 'q2view_file_url_qp': $q2view_file.qp } }</url>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work? Is the url % { mapping something (like URI-encoding) over the object? Or are we assigning into a scope of some sort?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url comes from the 'url' column of the q2view_display.loc.sample file. This is just doing standard dictionary-based string replacement.

The .qp attribute of $q2view_file calls urllib.parse.quote_plus on the URL generated for q2view_file.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just doing standard dictionary-based string replacement.

oh. duh! Thanks!

The .qp attribute of $q2view_file calls urllib.parse.quote_plus on the URL generated for q2view_file.

Ah, neat!

@@ -0,0 +1,3 @@
# Table used for listing simple Intermine display servers
#<unique_id> <display_name> <url>
main_q2view qiime2view https://view.qiime2.org/visualization/?type=html&src=%(q2view_file_url_qp)s
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will q2_view_file_url_qp be URI encoded?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that happens in the .xml file.

We can also add additional servers by adding new lines here.

@ebolyen
Copy link
Owner

ebolyen commented Aug 21, 2018

This is very cool!

@ebolyen ebolyen merged commit 09bbbfd into ebolyen:qiime2 Jan 17, 2019
ebolyen pushed a commit that referenced this pull request Feb 16, 2021
ebolyen pushed a commit that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants