-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add q2view display application. #1
Conversation
<?xml version="1.0"?> | ||
<display id="q2view" version="1.0.0" name="view at"> | ||
<dynamic_links from_data_table="q2view_display" skip_startswith="#" id="value" name="name"> | ||
<url>${ url % { 'q2view_file_url_qp': $q2view_file.qp } }</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work? Is the url % {
mapping something (like URI-encoding) over the object? Or are we assigning into a scope of some sort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url
comes from the 'url' column of the q2view_display.loc.sample
file. This is just doing standard dictionary-based string replacement.
The .qp
attribute of $q2view_file
calls urllib.parse.quote_plus
on the URL generated for q2view_file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just doing standard dictionary-based string replacement.
oh. duh! Thanks!
The .qp attribute of $q2view_file calls urllib.parse.quote_plus on the URL generated for q2view_file.
Ah, neat!
tool-data/q2view_display.loc.sample
Outdated
@@ -0,0 +1,3 @@ | |||
# Table used for listing simple Intermine display servers | |||
#<unique_id> <display_name> <url> | |||
main_q2view qiime2view https://view.qiime2.org/visualization/?type=html&src=%(q2view_file_url_qp)s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will q2_view_file_url_qp
be URI encoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that happens in the .xml file.
We can also add additional servers by adding new lines here.
This is very cool! |
Add select and <filter> example
Pull John's updates into my branch
Requires configuring CORS and using https on Galaxy with these default settings.