Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please implement RFC3161 timestamping #7

Closed
nextgens opened this issue Oct 23, 2014 · 4 comments
Closed

Please implement RFC3161 timestamping #7

nextgens opened this issue Oct 23, 2014 · 4 comments
Labels
enhancement
Milestone
1.3

Comments

@nextgens
Copy link
Contributor

SignTool (4.0 and later) use RFC3161 like all non-microsoft tools
@ebourg
Copy link
Owner

ebourg commented Oct 28, 2014

The PR #8 seems to be incomplete, on Windows 7 I can't see the RFC 3161 timestamp of target/test-classes/wineyes-timestamped.exeafter running PESignerTest.

@ebourg ebourg reopened this Oct 28, 2014
@nextgens
Copy link
Contributor Author

reqgen.setCertReq(true); makes it appear (I have the timestamping server's intermediate CA in my trust store)... but then again, windows is still failing to verify the countersignature... Reading the spec I'm still unclear on what should be signed. Any idea?

@ebourg
Copy link
Owner

ebourg commented Oct 29, 2014

I haven't found a spec for Authenticode with RFC 3161 timestamps yet, do you have link?

ebourg pushed a commit that referenced this issue Nov 5, 2014
@nextgens @ebourg
Fixed the TSP request to make the timestamp visible in the signature …
fc38b17 
…window (#7)
@nedtwigg nedtwigg mentioned this issue Feb 9, 2016
Closed
@ebourg ebourg added this to the 1.3 milestone Mar 14, 2016
@ebourg ebourg closed this as completed in 6ca0e74 Mar 15, 2016
@nedtwigg
Copy link

Hurrah! Thanks so much @ebourg! I'll test this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
3 participants
@ebourg @nextgens @nedtwigg