Replace function does not replace all occurences #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace function did not replace all classes, script failed on clicking dom items with more then 2 classes
ebrehault
added a commit
that referenced
this pull request
Aug 1, 2013
Replace function does not replace all occurences
|
hey @ebrehault thanx for merging, when are you going to update the chrome extension? :) |
|
I just did :) thanks for contributing |
|
Sure thing! Love this! Tired of writing them manually On Thu, Aug 1, 2013 at 6:43 PM, Eric BREHAULT notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace function did not replace all classes, script failed on clicking dom items with more then 2 classes.
This adds replace with a regex replace with a global flag to replace all occurrences, as well as trimming it so cases lik class=" btn" won't break the code