Improved Loading State Tracking #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a tally of items that are loading, store a hash of id:boolean pairs, each pair representing the loading state of one item.
Change to use more efficient loop structure.
I understand Leaflet Events better now. This removes some silliness I added due to my lack of knowledge.
|
This is great, @codefox421! I changed the code a bit to make it IE 7/8 compatible (as Leaflet is or tries to be) in d052a17, but I think it's a little clearer, too. Will get at the other two PRs soon. Please use four spaces instead of hard tabs for consistency. I'm going to document that for other contributors. Otherwise, thanks a ton! |
|
Thank you for the compatibility fix! I was considering removing Object.keys myself, but I didn't find it necessary mostly because I didn't know about the lack of support in IE 7/8. Anyhow, your new method of checking the loading state and updating the indicator is much more elegant. Duly noted about the spaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a tally of items that are loading, store a hash of id:boolean pairs, each pair representing the loading state of one item. This is particularly useful when a layer does not finish loading all tiles before dispatching a new loading event.