-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass/Less support #1
Comments
😀 I'd love to help but am not sure where to start... Do preprocessors self-identify or would there need to be one-offs for each one? |
I think we would start by identifying additional file suffixes that we need to care about and then perhaps generate files with |
Just make sure stylus is supported ;) |
@ebryn if you support legal css, then you support every compiler's output. |
yeah we'll run into an issue with the Would somehow using css comments as a placeholder for class name injection work better? |
comments are a bad api. I would suggest just adhering to the css spec. E.g. component {
...
} would work just fine because it's a legal selector. If you need to control behavior, you can invent your own at rules... those will survive the compiler. |
Ah, that seems like a great solution |
I really want to use this, but I really don't want to go back to regular CSS :P 👍 from me |
I tried to monkey-patch sass support in by just using ENOENT: no such file or directory, scandir 'client/tmp/caching-writer-dest-dir_xPIU0A.tmp/app/'
Error: ENOENT: no such file or directory, scandir 'client/tmp/caching-writer-dest-dir_xPIU0A.tmp/app/'
at Error (native)
at Object.fs.readdirSync (fs.js:805:18)
at walkSync (client/node_modules/ember-component-css/node_modules/walk-sync/index.js:14:20)
at Funnel.processFilters (client/node_modules/ember-component-css/node_modules/broccoli-funnel/index.js:140:15)
at Funnel.handleReadTree (client/node_modules/ember-component-css/node_modules/broccoli-funnel/index.js:129:10)
at lib$rsvp$$internal$$tryCatch (client/node_modules/ember-component-css/node_modules/broccoli-funnel/node_modules/rsvp/dist/rsvp.js:489:16)
at lib$rsvp$$internal$$invokeCallback (client/node_modules/ember-component-css/node_modules/broccoli-funnel/node_modules/rsvp/dist/rsvp.js:501:17)
at lib$rsvp$$internal$$publish (client/node_modules/ember-component-css/node_modules/broccoli-funnel/node_modules/rsvp/dist/rsvp.js:472:11)
at lib$rsvp$asap$$flush (client/node_modules/ember-component-css/node_modules/broccoli-funnel/node_modules/rsvp/dist/rsvp.js:1290:9)
at process._tickCallback (node.js:349:13) This was just meant to be getting a quick and dirty solution, since I was looking for a solution like this for quite some time, but no idea what this error means. |
Really looking forward for using this in combination with Sass. Doesn't the new addon system allow for a simple integration of pre- / post-processors? |
Implementation strategy outlined here, if anyone wants to give it a go: #10 (comment) |
Opened a PR with one potential approach to solving this. Thoughts and opinions welcome! |
Multiple css classes webark#69
It should be possible to use with CSS preprocessors like Sass/Less
The text was updated successfully, but these errors were encountered: