New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component lookup fallback solution #145
Add component lookup fallback solution #145
Conversation
9ae375e
to
49c5d87
Compare
Using `owner.hasRegistration` does not work in Ember 1.13, so this falls back to something supported if the original approach is unavailable.
49c5d87
to
5fcb391
Compare
@alexlafroscia I thought that was what the get owner polyfill was doing.. but maybe not. I'm supprised there isn't a polyfill for this. And getting the testing back on track is something that needs to be handled. Im on vacation right now, so don't have a lot of time to look at it. |
Oh, maybe? I thought that that polyfill just allowed you to call |
It does look like that's what the |
@alexlafroscia maybe. I remember that was what @rwjblue suggested. I'm still on vacation for another week, so won't have a chance to look at it until I'm back. |
@alexlafroscia did you find another workaround for this or are you using a fork right now? I am also running into problems when using the addon in an 1.13.x-application. |
Aside from the one in the PR? No; we decided to install the add-on from my fork to get around the issue. |
@alexlafroscia is that ember try the new format? If it is, then everything looks fine and I can merge this and cut a release if you want. Sorry, forgot to pick this one back up after I got back! |
@webark I think its the new format, but maybe I'm wrong? I don't think it matters if you export an object or a function. At this point, I honestly don't remember why I switched to a function, but I was probably following the guideline at the time |
@alexlafroscia apparently you have to explicitly use the |
going to be closing this in favor of #153 when it gets merged. |
I recently upgraded to the latest beta to fix the issue with
app.import
breaking, and found that the use ofowner.hasRegistration
broke Ember 1.13. I tried to come up with a failing test case, but was unable to do so, because I wasn't able to follow what situations that code was called under. If you could guide me toward how to make a test case, I'd love to add one, but this at least fixes the issues in my app.