-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace deprecated contains
with includes
#456
replace deprecated contains
with includes
#456
Conversation
24808a4
to
3db88a3
Compare
Would love to see this merged! |
@ebryn might it be possible to either merge this and other valid PRs or perhaps give commit rights to someone else who can? Thanks |
@@ -335,7 +335,7 @@ test("should be able to set nonembedded relationship to null", function() { | |||
}); | |||
|
|||
equal(post.get('author'), null); | |||
deepEqual(post.toJSON(), {id: 1, author_id: null}); | |||
deepEqual(post.toJSON(), {id: 1, author_id: undefined}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eventualbuddha I'm not sure what change in Ember resulted in this change. I'll track it down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eventualbuddha perhaps you might be able to review this? LMK if you can't and I'll try find someone else |
Ping @GavinJoyce |
@eventualbuddha I've added some context to the reason that the test change was needed above. Good to merge? |
Thanks @GavinJoyce! |
2.8.3
)contains
withincludes
I'll address the
getOwner
deprecations once this has merged