Search load fix #101
Merged
Search load fix #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently non-functional, DO NOT MERGE
mmabrahamson
requested review from
efrierson,
cambw,
jjensen-ebsco and
CameronThomas-EBSCO
This was referenced May 11, 2021
|
I have applied the patch and tested it is working perfectly and EDS (Discovery) drop option are coming immediately once the page is loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #94 with the search taking a long time to load.
Many thanks to @kidclamp and @AndrewIsh for the help identifying this issue and potential solutions!
To Test:
Install on your Koha 20.05 server.
BE SURE that you go into "Configure" and click "save" after install, even if it stores old values. This builds the templates needed.
Check that everything is functioning as expected and that the dropdown is populating as needed.