Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up code to pass pep8 and add flake8 as a build check #526

Open
nigelmegitt opened this issue Dec 3, 2019 · 0 comments
Open

Fix up code to pass pep8 and add flake8 as a build check #526

nigelmegitt opened this issue Dec 3, 2019 · 0 comments
Assignees

Comments

@nigelmegitt
Copy link
Collaborator

There's a variety of coding styles used in the LIT at the moment, not too many, but also there's some lack of consistency, and lack of guidance to contributors for how to format the code they add.

Suggest doing a pass-through of the whole library to pass pep8, using the flake8 qa checker, and then add flake8 to the travisCI build script to check that new pull requests don't break it. Also add to the contributing readme to explain that we use pep8.

@nigelmegitt nigelmegitt self-assigned this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant