Iss297 R107 discard duplicate sequence pair #336
Conversation
Availability time is not a range
| Given an xml file <xml_file> | ||
| And it has sequence identifier <seq_id> | ||
| And it has sequence number <seq_n> | ||
| When a previous document exists with sequence identifier <prev_seq_id> and sequence number <prev_seq_n> |
There was a problem hiding this comment.
I think it makes more sense here to say that when the document is made available and then another document with the same id and number becomes available then when trying to add the second document it is not added. This BDD case never creates the first document, so all the work has to be done in "When a previous document exists..." which presumably creates the first document and adds it?
| And it has sequence number <seq_n> | ||
| When a previous document exists with sequence identifier <prev_seq_id> and sequence number <prev_seq_n> | ||
| And the previous document has availability time <prev_avail> | ||
| Then the previous document has availability time <post_avail> |
There was a problem hiding this comment.
I would refactor this one too - given a file with sequence id and number and it is added to the sequence with availability time <prev_avail> and an attempt is made to add a new file with same sequence id and number to the sequence then the availability time of the file in the sequence with that sequence id and number is <prev_avail>.
| When a document arrives | ||
| And it has sequence identifier <seq_id_2> | ||
| And it has sequence number <seq_n_2> | ||
| Then the previous document has availability time <avail_time_2> |
There was a problem hiding this comment.
Surely avail_time_1 and avail_time_2 are always the same in this case? What is the case where they would differ?
| When a document arrives | ||
| And it has sequence identifier <seq_id_2> | ||
| And it has sequence number <seq_n_2> | ||
| Then the previous document has availability time <avail_time_2> |
There was a problem hiding this comment.
Just wondering: "previous" -> "first" for more clarity ?
|
|
||
|
|
||
| | seq_id_1 | seq_n_1 | avail_time_1 | seq_id_2 | seq_n_2 | avail_time_2 | | ||
| | n | 1 | n | 1 | 00:00:00.000 | 00:00:00.000 | |
There was a problem hiding this comment.
What is n for an availability time?
There was a problem hiding this comment.
That makes more sense, thanks.
Obviously they need to be coded to make any sense, which would be one for @kozmaz87 to have a look at. Before going ahead, I'd like a time estimate please.
Scenarios for R107 and 108