Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin used Python 2 packages #539

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

spoeschel
Copy link
Collaborator

@spoeschel spoeschel commented Sep 21, 2020

Prevents issues like #533 in the future, as it is expected that further
dependencies will remove Python 2 support in the future.

The updated file has been generated using pip freeze and replacing the
repository path of the toolkit by .. The pkg-resources==0.0.0 line
has been removed, as it was present due to a bug.

The --index-url parameter has been removed, as the specified URL
meanwhile forwards to the default package index.

Closes #538.

Prevents issues like #533 in the future, as it is expected that further
dependencies will remove Python 2 support in the future.

The updated file has been generated using `pip freeze` and replacing the
repository path of the toolkit by `.`. The `pkg-resources==0.0.0` line
has been removed, as it was present due to [a bug](pypa/pip#4022).

The `--index-url` parameter has been removed, as the specified URL
meanwhile forwards to the default package index.

Implements #538.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.104% when pulling 8d48009 on issue-538-pin-used-python-2-packages into 4d5893a on release/2.1.3.

Copy link
Collaborator

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, builds and tests successfully, this is what we need for a stable release that will keep working for as long as the specified versions of upstream dependencies remain available.

@spoeschel spoeschel merged commit 52fc3e2 into release/2.1.3 Oct 8, 2020
@spoeschel spoeschel deleted the issue-538-pin-used-python-2-packages branch October 8, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants