🎨 replace var with const/let

ebullient · Mar 19, 2024 · f28ab14 · f28ab14
1 parent aca1de9
commit f28ab14
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 30 deletions.
diff --git a/plugin/reveal.js-elapsed-time-bar/elapsed-time-bar.js b/plugin/reveal.js-elapsed-time-bar/elapsed-time-bar.js
@@ -1,4 +1,4 @@
-var ElapsedTimeBar = {
+const ElapsedTimeBar = {
     id: 'elapsed-time-bar',
 
     // default value
@@ -18,7 +18,7 @@ var ElapsedTimeBar = {
      * initialize elements
      */
     handleReady() {
-        var config = Reveal.getConfig();
+        const config = Reveal.getConfig();
 
         // activate this plugin if config.allottedTime exists.
         if (!config.allottedTime) {
@@ -31,8 +31,8 @@ var ElapsedTimeBar = {
         this.pausedBarColor = config.pausedBarColor || this.pausedBarColor;
 
         // calc barHeight from config.barHeight or page-progress container
-        var barHeight;
-        var pageProgressContainer = document.querySelector('.progress');
+        let barHeight;
+        const pageProgressContainer = document.querySelector('.progress');
         if (config.progressBarHeight) {
             barHeight = parseInt(config.progressBarHeight, 10) + 'px';
 
@@ -47,7 +47,7 @@ var ElapsedTimeBar = {
         }
 
         // create container of time-progress
-        var timeProgressContainer = document.createElement('div');
+        const timeProgressContainer = document.createElement('div');
         timeProgressContainer.classList.add('progress');
         Object.entries({
             display: 'block',
@@ -79,8 +79,8 @@ var ElapsedTimeBar = {
      */
     loop() {
         if (this.isPaused) return;
-        var now = +new Date();
-        var elapsedTime = now - this.startTime - this.pauseTimeDuration;
+        const now = +new Date();
+        const elapsedTime = now - this.startTime - this.pauseTimeDuration;
         if (elapsedTime > this.allottedTime) {
             this.timeProgressBar.style.width = '100%';
             this.isFinished = true;

diff --git a/src/obsidian/processors/imageProcessor.ts b/src/obsidian/processors/imageProcessor.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-var */
-
 import { CommentParser } from '../comment';
 import { ObsidianUtils } from '../obsidianUtils';
 
@@ -88,10 +86,11 @@ export class ImageProcessor {
             : this.parser.buildComment('element');
 
         if (ext) {
+            let width, height;
             if (ext.includes('x')) {
-                var [width, height] = ext.split('x');
+                [width, height] = ext.split('x');
             } else {
-                var width = ext;
+                width = ext;
             }
             comment.addStyle('width', `${width}px`);
 

diff --git a/src/template/embed.html b/src/template/embed.html
@@ -26,7 +26,7 @@
             const itemsToFit = document.getElementsByClassName('fitText');
             for (const item in itemsToFit) {
                 if (Object.hasOwnProperty.call(itemsToFit, item)) {
-                    var element = itemsToFit[item];
+                    const element = itemsToFit[item];
                     fitElement(element, 1, 1000);
                     element.classList.remove('fitText');
                 }
@@ -78,10 +78,10 @@
 
     <script>
         function extend() {
-            var target = {};
-            for (var i = 0; i < arguments.length; i++) {
-                var source = arguments[i];
-                for (var key in source) {
+            const target = {};
+            for (let i = 0; i < arguments.length; i++) {
+                const source = arguments[i];
+                for (const key in source) {
                     if (source.hasOwnProperty(key)) {
                         target[key] = source[key];
                     }
@@ -105,7 +105,7 @@
             return brightness > 155;
         }
 
-        var bgColor = getComputedStyle(document.documentElement).getPropertyValue('--r-background-color').trim();
+        const bgColor = getComputedStyle(document.documentElement).getPropertyValue('--r-background-color').trim();
 
         if (isLight(bgColor)) {
             document.body.classList.add('has-light-background');
@@ -114,7 +114,7 @@
         }
 
         // default options to init reveal.js
-        var defaultOptions = {
+        const defaultOptions = {
             controls: false,
             progress: false,
             history: false,
@@ -136,9 +136,9 @@
         };
 
         // options from URL query string
-        var queryOptions = Reveal().getQueryHash() || {};
+        const queryOptions = Reveal().getQueryHash() || {};
 
-        var options = extend(defaultOptions, {{{ revealOptionsStr }}}, queryOptions);
+        const options = extend(defaultOptions, {{{ revealOptionsStr }}}, queryOptions);
         options.controls = false;
         options.progress = false;
         options.history = false;

diff --git a/src/template/reveal.html b/src/template/reveal.html
@@ -35,7 +35,7 @@
             return (window.location !== window.parent.location);
         }
 
-        var forgetPop = true;
+        let forgetPop = true;
         function onPopState(event) {
             if(forgetPop){
                 forgetPop = false;
@@ -55,7 +55,7 @@
             const itemsToFit = document.getElementsByClassName('fitText');
             for (const item in itemsToFit) {
                 if (Object.hasOwnProperty.call(itemsToFit, item)) {
-                    var element = itemsToFit[item];
+                    const element = itemsToFit[item];
                     fitElement(element, 1, 1000);
                     element.classList.remove('fitText');
                 }
@@ -135,10 +135,10 @@
 
     <script>
         function extend() {
-            var target = {};
-            for (var i = 0; i < arguments.length; i++) {
-                var source = arguments[i];
-                for (var key in source) {
+            const target = {};
+            for (let i = 0; i < arguments.length; i++) {
+                const source = arguments[i];
+                for (const key in source) {
                     if (source.hasOwnProperty(key)) {
                         target[key] = source[key];
                     }
@@ -162,7 +162,7 @@
             return brightness > 155;
         }
 
-        var bgColor = getComputedStyle(document.documentElement).getPropertyValue('--r-background-color').trim();
+        const bgColor = getComputedStyle(document.documentElement).getPropertyValue('--r-background-color').trim();
 
         if (isLight(bgColor)) {
             document.body.classList.add('has-light-background');
@@ -171,7 +171,7 @@
         }
 
         // default options to init reveal.js
-        var defaultOptions = {
+        const defaultOptions = {
             controls: true,
             progress: true,
             history: true,
@@ -253,9 +253,9 @@
         };
 
         // options from URL query string
-        var queryOptions = Reveal().getQueryHash() || {};
+        const queryOptions = Reveal().getQueryHash() || {};
 
-        var options = extend(defaultOptions, {{{ revealOptionsStr }}}, queryOptions);
+        const options = extend(defaultOptions, {{{ revealOptionsStr }}}, queryOptions);
     </script>
 
     <script>