This repository has been archived by the owner on May 2, 2023. It is now read-only.
refactor(demo): Pagebanner optional/mandatory knobs - FRONT-913 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joosthe
added
pr: review needed
planctus
added
pr: modification needed
and removed
pr: review needed
papegaill
suggested changes
Mar 17, 2020
| data.title = text('Title', data.title, buttonLabels.required); | ||
| } | ||
|
|
||
| if (data.title) { |
Joosthe
added
pr: review needed
|
As i already tried the first time, @Joosthe , it is better if you focus on one of the pull requests, i'd say the hero banner since it's where i left the comments, and only after we get to a satisfactory state in that pr you will touch again this, otherwise it's a duplicated work on your side and on the review side, ok? ;) |
planctus
added
pr: wip
Joosthe
changed the title
planctus
added
pr: review needed
planctus
approved these changes
Mar 20, 2020
papegaill
added
pr: under review
and removed
pr: review needed
papegaill
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)