This repository has been archived by the owner on May 2, 2023. It is now read-only.
refactor(knobs): Gallery optional/mandatory knobs -FRONT-926 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joosthe
added
pr: review needed
Joosthe
changed the title
planctus
added
pr: under review
pr: review needed
papegaill
added
pr: under review
and removed
pr: review needed
papegaill
suggested changes
Mar 27, 2020
| data.overlay.share.icon.path = defaultSprite; | ||
| const preperaGallery = data => { | ||
| data.items.forEach((item, index) => { | ||
| item.share_path = select( |
There was a problem hiding this comment.
What about the other parameters?
- "path"
- "alt"
- "meta"
- "icon"
There was a problem hiding this comment.
i didn't see them in the documentation in ecl for the gallery but i will put them in
| defaultSprite, | ||
| buttonLabels.required | ||
| ); | ||
| data.overlay.download.icon.path = select( |
There was a problem hiding this comment.
this is a link object, not only the icon.path should be a knob
| defaultSprite, | ||
| buttonLabels.required | ||
| ); | ||
| data.overlay.share.icon.path = select( |
There was a problem hiding this comment.
this is a link object, not only the icon.path should be a knob
planctus
added
pr: review needed
papegaill
added
pr: under review
and removed
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Please drop a few lines about the PR: what it does, how to test it, etc.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependenciesdevDependenciesincludeorembed) asdependencies@ecl-twig/ec-components'sdependenciesyarn.lockcontains changes, I have committed itpr: review neededto indicate that I'm done and now waiting for a review ,pr: wipto indicate that I'm actively working on it ...)