Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

refactor(demo): Language list, optional/mandatory knobs, fixing the notes plugin - FRONT-925 #393

Merged
merged 3 commits into from Mar 30, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Mar 26, 2020

PR description

WARNING!!! it contains an update of the storybook-addon-notes plugin, take care.

These are changes that were lost from a previous pr where i probably forgot to push the right file, these changes are fixing also the output in the notes of components like social media share and language list where we give the possibility the delete item by unsetting them through the knobs.
The output in the notes tab if you choose "none" as the label of an item should be clean, the item is removed from the demo and the include code doesn't contain the item.
The same happens also in the social mendia components, if you remove an icon the item is removed as well and in the notes tab the output of the include code should be clean.

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: enhancement labels Mar 26, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 30, 2020
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is correctly working on my side, notes correctly updated as expected. O k for language list knobs too.

@Joosthe Joosthe merged commit a2cc738 into develop Mar 30, 2020
@Joosthe Joosthe deleted the FRONT-925 branch March 30, 2020 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants