This repository has been archived by the owner on May 2, 2023. It is now read-only.
refactor(demo): Language list, optional/mandatory knobs, fixing the notes plugin - FRONT-925 #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
WARNING!!! it contains an update of the storybook-addon-notes plugin, take care.
These are changes that were lost from a previous pr where i probably forgot to push the right file, these changes are fixing also the output in the notes of components like social media share and language list where we give the possibility the delete item by unsetting them through the knobs.
The output in the notes tab if you choose "none" as the label of an item should be clean, the item is removed from the demo and the include code doesn't contain the item.
The same happens also in the social mendia components, if you remove an icon the item is removed as well and in the notes tab the output of the include code should be clean.
QA Checklist
In order to ensure a safe and quick review, please check that your PR follow those guidelines:
devDependencies
devDependencies
include
orembed
) asdependencies
@ecl-twig/ec-components
'sdependencies
yarn.lock
contains changes, I have committed itpr: review needed
to indicate that I'm done and now waiting for a review ,pr: wip
to indicate that I'm actively working on it ...)