Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

feat(menuV2): Implementation, green diff with ECL - FRONT-991 #394

Merged
merged 7 commits into from Mar 31, 2020

Conversation

planctus
Copy link
Contributor

@planctus planctus commented Mar 27, 2020

PR description

To reproduce the diff with the ECL markup:
render the component
yarn check:component ec menu
run the ecl-diff script:
yarn ecl-diff ec

the choiches you have to make are:

  • "menu as the component
  • "en" as the twig variant
  • choose "navigation" from the subsections
    You get it ;)

QA Checklist

In order to ensure a safe and quick review, please check that your PR follow those guidelines:

  • I have put the vanilla component as devDependencies
  • I have put the specs package as devDependencies
  • I have added the components directly used in the twig file (with include or embed) as dependencies
  • My component is listed in @ecl-twig/ec-components's dependencies
  • My variables naming follow the guidelines (snake case for twig)
  • I have provided tests
  • I have provided documentation (for the "notes" tab)
  • If my local yarn.lock contains changes, I have committed it
  • I have given my PR the proper label (pr: review needed to indicate that I'm done and now waiting for a review ,pr: wip to indicate that I'm actively working on it ...)

@planctus planctus added pr: review needed Use this label to show that your PR needs to be review tag: breaking change tag: new feature labels Mar 27, 2020
@papegaill papegaill added pr: under review and removed pr: review needed Use this label to show that your PR needs to be review labels Mar 30, 2020
papegaill
papegaill previously approved these changes Mar 30, 2020
Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me, can be merged 👍
Resolved conflicts with develop merge, and I think we have some general issues with drone.

@planctus
Copy link
Contributor Author

Ok, cool, the issue with drone should be fixed ;)

@papegaill papegaill merged commit c86c116 into develop Mar 31, 2020
@papegaill papegaill deleted the FRONT-991 branch March 31, 2020 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants