This repository has been archived by the owner on May 2, 2023. It is now read-only.
feat(gallery): Component and resources updates for v2.29.0 - FRONT-1222 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
added
pr: review needed
emeryro
added
pr: under review
and removed
pr: review needed
emeryro
suggested changes
Jun 16, 2020
|
Thanks @emeryro ..fixed it ;) |
planctus
added
pr: review needed
emeryro
approved these changes
Jun 16, 2020
emeryro
removed
the
pr: review needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Component aligned with ecl 2.29.0.
It is possible to retrieve the diff between our rendered html and the ecl one:
yarn check:component ec galleryyarn ecl-diff ec,choose gallery, all the other options are already fine, just skip them.