Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(etls): add interreg 2014TC16M4TN001 - EUBFR-258 #210

Merged
merged 11 commits into from May 23, 2019

Conversation

kalinchernev
Copy link
Contributor

PR description

Please drop a few lines about the PR: what it does, how to test it, etc.

QA Checklist

When you add a new ETL/producer, please check for the following:

  • Ensure the ETL has been correctly setup following the guide in services/ingestion/etl/README.md
  • There is at least 1 sample record.json and 1 unit test with a jest snapshot for the result of the transform function of the ETL.
  • Ensure there is (flow/jsdocs) documentation in the transform function
  • Generate the necessary documentation pages for the new ETL by yarn docs:md

*/

const getBudget = record => {
const euContrib =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or record['ERDF'] + record['IPA Funds'], it gives you the same result :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is to use the Amount of the project (ERDF +IPA + national counterpart) field which is used for the total, which could also be a result of the mentioned fields. I think it's good for now with the 2 fields used.

Copy link
Contributor

@yhuard yhuard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and tested ✅

@yhuard yhuard removed their assignment May 23, 2019
@kalinchernev kalinchernev merged commit e9887a5 into master May 23, 2019
@kalinchernev kalinchernev deleted the feat/etl-interreg-2014TC16M4TN001-EUBFR-258 branch May 23, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants