feat(elasticsearch): improve mappings - EUBFR-88 #55
Conversation
|
Removing the |
| @@ -7,6 +7,8 @@ import split2 from 'split2'; | |||
|
|
|||
| import deleteProjects from '../lib/deleteProjects'; | |||
| import SaveStream from '../lib/SaveStream'; | |||
| // elasticsearch mapping https://goo.gl/MEGiA6 | |||
There was a problem hiding this comment.
Please don't use Google's URL shortener... please...
There was a problem hiding this comment.
I didn't find one for the EC and links are sometimes too long and ugly
| project_locations: { | ||
| properties: { | ||
| location: { | ||
| type: 'geo_point', |
There was a problem hiding this comment.
Should be geo_shape https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-shape.html
There was a problem hiding this comment.
I'd suggest this change to happen in EUBFR-98 where we ensure the transform is also updated?
| properties: { | ||
| location: { | ||
| type: 'geo_point', | ||
| ignore_malformed: true, |
There was a problem hiding this comment.
Is there a specific reason for ignore_malformed: true?
There was a problem hiding this comment.
This one I added before we make latitude and longitude 0 if not available. If a value is not 0, but null and type is geo_something as in most defaults in our case, indexing fails and stops the process.
kalinchernev
force-pushed
the
feat/elasticsearch-mapping-EUBFR-88
branch
from
5ed8c9c
to
a7582e4
Compare
Todos after feedback from Rainer:
Deployed stage
chernka30, so far do not yield errors on portal side => works.I'm awaiting some additional feedback from Rainer if there are some other tweaks necessary before we merge as
teststage is frozen for the time being.